chore: gate on task being paused

DanielleMaywood · DanielleMaywood · commit 3c7204c25839 · 2025-11-25T10:51:13.000Z
diff --git a/coderd/aitasks.go b/coderd/aitasks.go
@@ -701,9 +701,9 @@ func (api *API) taskUpdateInput(rw http.ResponseWriter, r *http.Request) {
 			})
 		}
 
-		if task.Status == database.TaskStatusInitializing || task.Status == database.TaskStatusActive {
+		if task.Status != database.TaskStatusPaused {
 			return httperror.NewResponseError(http.StatusConflict, codersdk.Response{
-				Message: "Cannot update input while task is initializing or active.",
+				Message: "Unable to update task input, task must be paused.",
 				Detail:  "Please stop the task's workspace before updating the input.",
 			})
 		}
diff --git a/coderd/aitasks_test.go b/coderd/aitasks_test.go
@@ -759,7 +759,7 @@ func TestTasks(t *testing.T) {
 				disableProvisioner: true,
 				taskInput:          "Valid prompt",
 				wantStatus:         codersdk.TaskStatusInitializing,
-				wantErr:            "Cannot update input",
+				wantErr:            "Unable to update",
 				wantErrStatusCode:  http.StatusConflict,
 			},
 			{
@@ -769,11 +769,13 @@ func TestTasks(t *testing.T) {
 				wantStatus: codersdk.TaskStatusPaused,
 			},
 			{
-				name:             "TaskStatusError",
-				transition:       database.WorkspaceTransitionStart,
-				cancelTransition: true,
-				taskInput:        "Valid prompt",
-				wantStatus:       codersdk.TaskStatusError,
+				name:              "TaskStatusError",
+				transition:        database.WorkspaceTransitionStart,
+				cancelTransition:  true,
+				taskInput:         "Valid prompt",
+				wantStatus:        codersdk.TaskStatusError,
+				wantErr:           "Unable to update",
+				wantErrStatusCode: http.StatusConflict,
 			},
 			{
 				name:       "EmptyPrompt",
@@ -864,10 +866,12 @@ func TestTasks(t *testing.T) {
 						require.Equal(t, tt.wantErrStatusCode, apiErr.StatusCode())
 					}
 
-					// Then: We expect the input to **not** be updated
-					task, err = exp.TaskByID(ctx, task.ID)
-					require.NoError(t, err)
-					require.NotEqual(t, tt.taskInput, task.InitialPrompt)
+					if !tt.deleteTask {
+						// Then: We expect the input to **not** be updated
+						task, err = exp.TaskByID(ctx, task.ID)
+						require.NoError(t, err)
+						require.NotEqual(t, tt.taskInput, task.InitialPrompt)
+					}
 				} else {
 					require.NoError(t, err)
 

Original file line number	Diff line number	Diff line change
`@@ -701,9 +701,9 @@ func (api API) taskUpdateInput(rw http.ResponseWriter, r http.Request) {`
`701`	`701`	`})`
`702`	`702`	`}`
`703`	`703`
`704`		`- if task.Status == database.TaskStatusInitializing \|\| task.Status == database.TaskStatusActive {`
	`704`	`+ if task.Status != database.TaskStatusPaused {`
`705`	`705`	`return httperror.NewResponseError(http.StatusConflict, codersdk.Response{`
`706`		`- Message: "Cannot update input while task is initializing or active.",`
	`706`	`+ Message: "Unable to update task input, task must be paused.",`
`707`	`707`	`Detail: "Please stop the task's workspace before updating the input.",`
`708`	`708`	`})`
`709`	`709`	`}`