fix: use useEffect for value prop handling in MultiSelectCombobox

blink-so[bot] · jaaydenh · blink-so[bot] · commit 369599d8e168 · 2025-07-23T16:43:37.000Z
Replaces the problematic reference comparison with proper useEffect
to handle controlled value prop updates. This ensures that when the
value prop changes, the selected state is properly updated.

Co-authored-by: jaaydenh &lt;1858163+jaaydenh@users.noreply.github.com&gt;
diff --git a/site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx b/site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx
@@ -223,11 +223,12 @@ export const MultiSelectCombobox = forwardRef<
 		const [inputValue, setInputValue] = useState("");
 		const debouncedSearchTerm = useDebouncedValue(inputValue, delay || 500);
 
-		const [previousValue, setPreviousValue] = useState<Option[]>(value || []);
-		if (value && value !== previousValue) {
-			setPreviousValue(value);
-			setSelected(value);
-		}
+		// Handle controlled value prop
+		useEffect(() => {
+			if (value) {
+				setSelected(value);
+			}
+		}, [value]);
 
 		useImperativeHandle(
 			ref,
