Skip to content

Commit 1c700a6

Browse files
authored
Merge branch 'main' into jaaydenh/refactor-copyable-value
2 parents e6a3bc9 + f2a1a7e commit 1c700a6

File tree

609 files changed

+30898
-10815
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

609 files changed

+30898
-10815
lines changed

.claude/docs/TROUBLESHOOTING.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,23 +91,31 @@
9191

9292
## Systematic Debugging Approach
9393

94+
YOU MUST ALWAYS find the root cause of any issue you are debugging
95+
YOU MUST NEVER fix a symptom or add a workaround instead of finding a root cause, even if it is faster.
96+
9497
### Multi-Issue Problem Solving
9598

9699
When facing multiple failing tests or complex integration issues:
97100

98101
1. **Identify Root Causes**:
99102
- Run failing tests individually to isolate issues
100103
- Use LSP tools to trace through call chains
101-
- Check both compilation and runtime errors
104+
- Read Error Messages Carefully: Check both compilation and runtime errors
105+
- Reproduce Consistently: Ensure you can reliably reproduce the issue before investigating
106+
- Check Recent Changes: What changed that could have caused this? Git diff, recent commits, etc.
107+
- When You Don't Know: Say "I don't understand X" rather than pretending to know
102108
103109
2. **Fix in Logical Order**:
104110
- Address compilation issues first (imports, syntax)
105111
- Fix authorization and RBAC issues next
106112
- Resolve business logic and validation issues
107113
- Handle edge cases and race conditions last
114+
- IF your first fix doesn't work, STOP and re-analyze rather than adding more fixes
108115
109116
3. **Verification Strategy**:
110-
- Test each fix individually before moving to next issue
117+
- Always Test each fix individually before moving to next issue
118+
- Verify Before Continuing: Did your test work? If not, form new hypothesis - don't add more fixes
111119
- Use `make lint` and `make gen` after database changes
112120
- Verify RFC compliance with actual specifications
113121
- Run comprehensive test suites before considering complete

.claude/docs/WORKFLOWS.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,15 @@
4040
- Use proper error types
4141
- Pattern: `xerrors.Errorf("failed to X: %w", err)`
4242

43-
### Naming Conventions
43+
## Naming Conventions
4444

45-
- Use clear, descriptive names
46-
- Abbreviate only when obvious
45+
- Names MUST tell what code does, not how it's implemented or its history
4746
- Follow Go and TypeScript naming conventions
47+
- When changing code, never document the old behavior or the behavior change
48+
- NEVER use implementation details in names (e.g., "ZodValidator", "MCPWrapper", "JSONParser")
49+
- NEVER use temporal/historical context in names (e.g., "LegacyHandler", "UnifiedTool", "ImprovedInterface", "EnhancedParser")
50+
- NEVER use pattern names unless they add clarity (e.g., prefer "Tool" over "ToolFactory")
51+
- Abbreviate only when obvious
4852

4953
### Comments
5054

.github/.linkspector.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,6 @@ ignorePatterns:
2626
- pattern: "claude.ai"
2727
- pattern: "splunk.com"
2828
- pattern: "stackoverflow.com/questions"
29+
- pattern: "developer.hashicorp.com/terraform/language"
2930
aliveStatusCodes:
3031
- 200

.github/actions/setup-go/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: |
44
inputs:
55
version:
66
description: "The Go version to use."
7-
default: "1.24.6"
7+
default: "1.24.10"
88
use-preinstalled-go:
99
description: "Whether to use preinstalled Go."
1010
default: "false"

.github/actions/setup-sqlc/action.yaml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@ runs:
55
using: "composite"
66
steps:
77
- name: Setup sqlc
8-
uses: sqlc-dev/setup-sqlc@c0209b9199cd1cce6a14fc27cabcec491b651761 # v4.0.0
9-
with:
10-
sqlc-version: "1.27.0"
8+
# uses: sqlc-dev/setup-sqlc@c0209b9199cd1cce6a14fc27cabcec491b651761 # v4.0.0
9+
# with:
10+
# sqlc-version: "1.30.0"
11+
12+
# Switched to coder/sqlc fork to fix ambiguous column bug, see:
13+
# - https://github.com/coder/sqlc/pull/1
14+
# - https://github.com/sqlc-dev/sqlc/pull/4159
15+
shell: bash
16+
run: |
17+
CGO_ENABLED=1 go install github.com/coder/sqlc/cmd/sqlc@aab4e865a51df0c43e1839f81a9d349b41d14f05

.github/actions/setup-tf/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ runs:
77
- name: Install Terraform
88
uses: hashicorp/setup-terraform@b9cd54a3c349d3f38e8881555d616ced269862dd # v3.1.2
99
with:
10-
terraform_version: 1.13.0
10+
terraform_version: 1.13.4
1111
terraform_wrapper: false

.github/fly-wsproxies/sao-paulo-coder.toml

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)