Code refactor

furkanaskin · furkanaskin · commit 37cbf52c0d1f · 2019-12-30T14:09:01.000+03:00
diff --git a/app/src/main/java/com/faskn/app/weatherapp/domain/usecase/ForecastUseCase.kt b/app/src/main/java/com/faskn/app/weatherapp/domain/usecase/ForecastUseCase.kt
@@ -5,6 +5,7 @@ import androidx.lifecycle.Transformations
 import com.faskn.app.weatherapp.core.Constants
 import com.faskn.app.weatherapp.db.entity.ForecastEntity
 import com.faskn.app.weatherapp.repo.ForecastRepository
+import com.faskn.app.weatherapp.ui.dashboard.ForecastMapper
 import com.faskn.app.weatherapp.ui.dashboard.ForecastViewState
 import com.faskn.app.weatherapp.utils.UseCaseLiveData
 import com.faskn.app.weatherapp.utils.domain.Resource
@@ -35,6 +36,9 @@ class ForecastUseCase @Inject internal constructor(private val repository: Forec
     }
 
     private fun onForecastResultReady(resource: Resource<ForecastEntity>): ForecastViewState {
+        val mappedList = resource.data?.list?.let { ForecastMapper().mapFrom(it) }
+        resource.data?.list = mappedList
+
         return ForecastViewState(
             status = resource.status,
             error = resource.message,
diff --git a/app/src/main/java/com/faskn/app/weatherapp/ui/dashboard/DashboardFragment.kt b/app/src/main/java/com/faskn/app/weatherapp/ui/dashboard/DashboardFragment.kt
@@ -80,6 +80,6 @@ class DashboardFragment : BaseFragment<DashboardFragmentViewModel, FragmentDashb
     }
 
     private fun initForecast(list: List<ListItem>) {
-        (mBinding.recyclerForecast.adapter as ForecastAdapter).submitList(ForecastMapper().mapFrom(list))
+        (mBinding.recyclerForecast.adapter as ForecastAdapter).submitList(list)
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,6 @@ class DashboardFragment : BaseFragment<DashboardFragmentViewModel, FragmentDashb`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`private fun initForecast(list: List<ListItem>) {`
`83`		`- (mBinding.recyclerForecast.adapter as ForecastAdapter).submitList(ForecastMapper().mapFrom(list))`
	`83`	`+ (mBinding.recyclerForecast.adapter as ForecastAdapter).submitList(list)`
`84`	`84`	`}`
`85`	`85`	`}`