fix(session): correctly remove routes on session close #1037
+888
−340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michele Papalini <micpapal@cisco.com>
Signed-off-by: Michele Papalini <micpapal@cisco.com>
Signed-off-by: Michele Papalini <micpapal@cisco.com>
Signed-off-by: Michele Papalini <micpapal@cisco.com>
Signed-off-by: Michele Papalini <micpapal@cisco.com>
Signed-off-by: Michele Papalini <micpapal@cisco.com>
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Signed-off-by: Michele Papalini <micpapal@cisco.com>
2af8a7d to
4c3568b
Compare
Co-authored-by: Mauro Sardara <msardara@cisco.com> Signed-off-by: Michele Papalini <49271675+micpapal@users.noreply.github.com>
Co-authored-by: Mauro Sardara <msardara@cisco.com> Signed-off-by: Michele Papalini <49271675+micpapal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes session route cleanup so that routes are correctly removed when sessions close. In particular the fix introduces a ref count for each route so that if multiple sessions use the same route, the route is removed only if the ref count goes to 0.
The PR improves the testing for P2P application to test 2 sessions in parallel.
fix #1033
Type of Change
Checklist