From fa7849d43fd8a1620f1e0f91aec1fa073049cd85 Mon Sep 17 00:00:00 2001 From: Shahar Naveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Sat, 19 Jul 2025 11:21:29 +0200 Subject: [PATCH 1/3] Pin rustc nightly to `nightly-2025-07-18` for miri tests --- .github/workflows/ci.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 89148beea4..6a8fcb8584 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -352,14 +352,15 @@ jobs: - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@master with: - toolchain: nightly + toolchain: nightly-2025-07-18 # TODO: Set to "nightly" once https://github.com/rust-lang/rust/issues/144168 is fixed components: miri - uses: Swatinem/rust-cache@v2 - name: Run tests under miri # miri-ignore-leaks because the type-object circular reference means that there will always be # a memory leak, at least until we have proper cyclic gc - run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +nightly miri test -p rustpython-vm -- miri_test + # run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +nightly miri test -p rustpython-vm -- miri_test + run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +nightly-2025-07-18 miri test -p rustpython-vm -- miri_test wasm: if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip:ci') }} From 6b1e4a7964648735348148bec7c25bd8794fdc6e Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Sat, 19 Jul 2025 11:30:43 +0200 Subject: [PATCH 2/3] Fix indent --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 6a8fcb8584..e3fbdb7de2 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -360,7 +360,7 @@ jobs: # miri-ignore-leaks because the type-object circular reference means that there will always be # a memory leak, at least until we have proper cyclic gc # run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +nightly miri test -p rustpython-vm -- miri_test - run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +nightly-2025-07-18 miri test -p rustpython-vm -- miri_test + run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +nightly-2025-07-18 miri test -p rustpython-vm -- miri_test wasm: if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip:ci') }} From 95880cee722ccb46f0016432e64e3853d13d8a55 Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Sat, 19 Jul 2025 11:42:49 +0200 Subject: [PATCH 3/3] Set the miri rustc channel via env var --- .github/workflows/ci.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index e3fbdb7de2..e25c327be9 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -348,19 +348,20 @@ jobs: name: Run tests under miri runs-on: ubuntu-latest timeout-minutes: 30 + env: + RUSTUP_TOOLCHAIN: nightly-2025-07-18 # TODO: Set to "nightly" once https://github.com/rust-lang/rust/issues/144168 is fixed steps: - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@master with: - toolchain: nightly-2025-07-18 # TODO: Set to "nightly" once https://github.com/rust-lang/rust/issues/144168 is fixed + toolchain: ${{ env.RUSTUP_TOOLCHAIN }} components: miri - uses: Swatinem/rust-cache@v2 - name: Run tests under miri # miri-ignore-leaks because the type-object circular reference means that there will always be # a memory leak, at least until we have proper cyclic gc - # run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +nightly miri test -p rustpython-vm -- miri_test - run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +nightly-2025-07-18 miri test -p rustpython-vm -- miri_test + run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +${{ env.RUSTUP_TOOLCHAIN }} miri test -p rustpython-vm -- miri_test wasm: if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip:ci') }}