From e84ecafecdf86f4b5287b265541b4953ea42850e Mon Sep 17 00:00:00 2001 From: Jeong YunWon Date: Thu, 2 Jan 2020 16:59:11 +0900 Subject: [PATCH] bump up num-bigint to 0.2.4 to fix modpow --- Cargo.lock | 12 ++++++------ tests/snippets/builtin_pow.py | 16 ---------------- vm/Cargo.toml | 2 +- 3 files changed, 7 insertions(+), 23 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 67b1b5a1ce..b3b4e38a3b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -797,7 +797,7 @@ dependencies = [ [[package]] name = "num-bigint" -version = "0.2.3" +version = "0.2.4" source = "registry+https://github.com/rust-lang/crates.io-index" dependencies = [ "autocfg 0.1.6 (registry+https://github.com/rust-lang/crates.io-index)", @@ -841,7 +841,7 @@ version = "0.2.2" source = "registry+https://github.com/rust-lang/crates.io-index" dependencies = [ "autocfg 0.1.6 (registry+https://github.com/rust-lang/crates.io-index)", - "num-bigint 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)", + "num-bigint 0.2.4 (registry+https://github.com/rust-lang/crates.io-index)", "num-integer 0.1.41 (registry+https://github.com/rust-lang/crates.io-index)", "num-traits 0.2.8 (registry+https://github.com/rust-lang/crates.io-index)", ] @@ -1244,7 +1244,7 @@ dependencies = [ "bincode 1.2.0 (registry+https://github.com/rust-lang/crates.io-index)", "bitflags 1.2.0 (registry+https://github.com/rust-lang/crates.io-index)", "lz4-compress 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)", - "num-bigint 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)", + "num-bigint 0.2.4 (registry+https://github.com/rust-lang/crates.io-index)", "num-complex 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)", "serde 1.0.101 (registry+https://github.com/rust-lang/crates.io-index)", ] @@ -1282,7 +1282,7 @@ dependencies = [ "lalrpop 0.17.2 (registry+https://github.com/rust-lang/crates.io-index)", "lalrpop-util 0.17.2 (registry+https://github.com/rust-lang/crates.io-index)", "log 0.4.8 (registry+https://github.com/rust-lang/crates.io-index)", - "num-bigint 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)", + "num-bigint 0.2.4 (registry+https://github.com/rust-lang/crates.io-index)", "num-traits 0.2.8 (registry+https://github.com/rust-lang/crates.io-index)", "regex 1.3.1 (registry+https://github.com/rust-lang/crates.io-index)", "unic-emoji-char 0.9.0 (registry+https://github.com/rust-lang/crates.io-index)", @@ -1325,7 +1325,7 @@ dependencies = [ "maplit 1.0.2 (registry+https://github.com/rust-lang/crates.io-index)", "md-5 0.8.0 (registry+https://github.com/rust-lang/crates.io-index)", "nix 0.15.0 (registry+https://github.com/rust-lang/crates.io-index)", - "num-bigint 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)", + "num-bigint 0.2.4 (registry+https://github.com/rust-lang/crates.io-index)", "num-complex 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)", "num-integer 0.1.41 (registry+https://github.com/rust-lang/crates.io-index)", "num-iter 0.1.39 (registry+https://github.com/rust-lang/crates.io-index)", @@ -2248,7 +2248,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" "checksum nix 0.15.0 (registry+https://github.com/rust-lang/crates.io-index)" = "3b2e0b4f3320ed72aaedb9a5ac838690a8047c7b275da22711fddff4f8a14229" "checksum nodrop 0.1.14 (registry+https://github.com/rust-lang/crates.io-index)" = "72ef4a56884ca558e5ddb05a1d1e7e1bfd9a68d9ed024c21704cc98872dae1bb" "checksum nom 4.2.3 (registry+https://github.com/rust-lang/crates.io-index)" = "2ad2a91a8e869eeb30b9cb3119ae87773a8f4ae617f41b1eb9c154b2905f7bd6" -"checksum num-bigint 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)" = "f9c3f34cdd24f334cb265d9bf8bfa8a241920d026916785747a92f0e55541a1a" +"checksum num-bigint 0.2.4 (registry+https://github.com/rust-lang/crates.io-index)" = "343b3df15c945a59e72aae31e89a7cfc9e11850e96d4fde6fed5e3c7c8d9c887" "checksum num-complex 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)" = "fcb0cf31fb3ff77e6d2a6ebd6800df7fdcd106f2ad89113c9130bcd07f93dffc" "checksum num-integer 0.1.41 (registry+https://github.com/rust-lang/crates.io-index)" = "b85e541ef8255f6cf42bbfe4ef361305c6c135d10919ecc26126c4e5ae94bc09" "checksum num-iter 0.1.39 (registry+https://github.com/rust-lang/crates.io-index)" = "76bd5272412d173d6bf9afdf98db8612bbabc9a7a830b7bfc9c188911716132e" diff --git a/tests/snippets/builtin_pow.py b/tests/snippets/builtin_pow.py index 1df2e2882a..acdbb7b60a 100644 --- a/tests/snippets/builtin_pow.py +++ b/tests/snippets/builtin_pow.py @@ -56,14 +56,6 @@ def powtest(type): for i in range(il, ih + 1): for j in range(jl, jh + 1): for k in range(kl, kh + 1): - if j == 1 and k % 2 == 0: - # FIXME: num-bigint bug for this case - # https://github.com/rust-num/num-bigint/pull/113 - continue - if i < 0 or k < 0: - # FIXME: num-bigint bug for negative base or mod - # https://github.com/rust-num/num-bigint/pull/114 - continue if k != 0: if type == float or j < 0: assert_raises(TypeError, pow, type(i), j, k) @@ -100,14 +92,6 @@ def test_other(): for i in range(-10, 11): for j in range(0, 6): - if j == 1: - # FIXME: num-bigint bug for this case - # https://github.com/rust-num/num-bigint/pull/113 - continue - if i < 0: - # FIXME: num-bigint bug for negative base - # https://github.com/rust-num/num-bigint/pull/114 - continue for k in range(-7, 11): if j >= 0 and k != 0: assert_equal( diff --git a/vm/Cargo.toml b/vm/Cargo.toml index ccd0cc89b2..e9748b8449 100644 --- a/vm/Cargo.toml +++ b/vm/Cargo.toml @@ -25,7 +25,7 @@ sha3 = "0.8" blake2 = "0.8" num-complex = { version = "0.2.2", features = ["serde"] } -num-bigint = { version = "0.2.3", features = ["serde"] } +num-bigint = { version = "0.2.4", features = ["serde"] } num-traits = "0.2.8" num-integer = "0.1.41" num-rational = "0.2.2"