-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Comparing changes
Open a pull request
base repository: JetBrains/kotlin
base: v1.2.30
head repository: JetBrains/kotlin
compare: 1.2.30
- 12 commits
- 26 files changed
- 10 contributors
Commits on Mar 13, 2018
-
Remove Redundant Backticks: Fix inspection applicability
#KT-22804 Fixed (cherry picked from commit a194eb9)
Configuration menu - View commit details
-
Copy full SHA for 7154315 - Browse repository at this point
Copy the full SHA 7154315View commit details
Commits on Mar 14, 2018
-
Fix binary incompatibility with Android Gradle plugin 3.2.0-alpha06
Remove a non-reflective usage of the ResourceSet class, which has been moved to a different package between versions. Access it through reflection instead. This is a workaround. We can introduce a proper fix once we have a public API in the Android plugin. The test case that could detect the compatibility issue is `testAndroidExtensionsManyVariants` (it uses experimental Android extensions), but we did not run it with 3.2.0-alpha6. This commit adds a test class with the same tests for 3.2.0-alpha6. Issue #KT-23192 Fixed (cherry picked from commit 0039be6)
Configuration menu - View commit details
-
Copy full SHA for f100e83 - Browse repository at this point
Copy the full SHA f100e83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7150fc0 - Browse repository at this point
Copy the full SHA 7150fc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c425e02 - Browse repository at this point
Copy the full SHA c425e02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d798b4 - Browse repository at this point
Copy the full SHA 3d798b4View commit details
Commits on Mar 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e43175b - Browse repository at this point
Copy the full SHA e43175bView commit details
Commits on Mar 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0a92d9c - Browse repository at this point
Copy the full SHA 0a92d9cView commit details -
Restore old package for ScriptTemplatesProvider.
Note that this is EP used in another plugins (ex. LivePlugin https://plugins.jetbrains.com/plugin/7282-liveplugin) (cherry picked from commit 82481b4)
Configuration menu - View commit details
-
Copy full SHA for ec490af - Browse repository at this point
Copy the full SHA ec490afView commit details -
Build: add maven.repository.mirror property
May be used to add additional repository to all projects
Configuration menu - View commit details
-
Copy full SHA for 8ddcd36 - Browse repository at this point
Copy the full SHA 8ddcd36View commit details
Commits on Mar 22, 2018
-
Hitting breakpoint in Kotlin sometimes doesn't work (KT-22205)
Fix KT-22205 and https://issuetracker.google.com/issues/71556313 Hitting breakpoints in Kotlin JUnit test with an Android Gradle project sometimes(*) does not work in Android Studio 3.1 beta. (*) The issue is related to various threads running concurrently with "dumb" mode background code, so the issue reproduces only on certain configurations. In a nutshell, the issue is as follows * On one hand, gradle build finishes, fires an event ("buildFinished") that is processed "later" and that causes the IDE to enter "dumb" mode for a shot amount of time (about 300-500 msec on a somewhat up to date multi-core computer). * On the other hand, once the JVM of the debuggee is started, breakpoints need to be resolved (on the debugger thread, through a call to com.intellij.debugger.engine.CompoundPositionManager.createPrepareRequests. This code calls into the "KotlinPositionManager.createPrepareRequests", which in turns calls into "PerFileAnalysisCache.analyze". That method returns "AnalysisResult.EMPTY" is the project is in dumb mode. This return value prevents callers from successfully resolving the source location into a breakpoint. Given that the 2 code paths above execute on separate threads without explicit synchronization, the "failed to resolve breakpoint" issue occurs sporadically, to the point it happens 100% of the time on certain configuration. The fix is so wrap the kotlin breakpoint resolution code inside a "runReadActionInSmartMode" so that the debugger thread "waits" for "dumb" mode to terminates before trying to resolve breakpoint locations. #KT-22205 Fixed (cherry picked from commit 94ee78c)
Configuration menu - View commit details
-
Copy full SHA for ad38c3e - Browse repository at this point
Copy the full SHA ad38c3eView commit details -
Fix compatibility with LivePlugin
^KT-23371 Fixed (cherry picked from commit c7513b5)
Configuration menu - View commit details
-
Copy full SHA for f4049e6 - Browse repository at this point
Copy the full SHA f4049e6View commit details
Commits on Mar 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3f71d36 - Browse repository at this point
Copy the full SHA 3f71d36View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.2.30...1.2.30