Skip to content

Commit fd2e580

Browse files
plaferplafer
authored
chore: rename miden-libcore to miden-core-lib (#2427)
1 parent 8603723 commit fd2e580

File tree

163 files changed

+174
-165
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

163 files changed

+174
-165
lines changed

‎.github/workflows/test.yml‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ jobs:
4343
- name: Run doc-tests
4444
run: make test-docs
4545

46-
check-libcore-docs:
47-
name: check libcore docs
46+
check-core-lib-docs:
47+
name: check core library docs
4848
runs-on: ubuntu-latest
4949
needs: [test, doc-tests]
5050
steps:
@@ -56,29 +56,29 @@ jobs:
5656
save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/next' }}
5757
- name: Install rust
5858
run: rustup update --no-self-update
59-
- name: Build libcore and generate documentation
59+
- name: Build core library and generate documentation
6060
run: |
61-
# Build libcore with documentation generation enabled
62-
MIDEN_BUILD_LIBCORE_DOCS=1 cargo build -p miden-libcore
63-
- name: Check for documentation changes in libcore/docs
61+
# Build core library with documentation generation enabled
62+
MIDEN_BUILD_LIB_DOCS=1 cargo build -p miden-core-lib
63+
- name: Check for documentation changes in crates/lib/core/docs
6464
run: |
65-
if [ -n "$(git status --porcelain libcore/docs)" ]; then
66-
echo "ERROR: Found uncommitted changes in libcore/docs/"
65+
if [ -n "$(git status --porcelain crates/lib/core/docs)" ]; then
66+
echo "ERROR: Found uncommitted changes in crates/lib/core/docs/"
6767
echo "This indicates that the assembly source code has changed but the documentation was not updated."
6868
echo "Please commit the generated documentation changes before merging."
6969
echo ""
7070
echo "To fix this:"
71-
echo "1. Run: MIDEN_BUILD_LIBCORE_DOCS=1 cargo build -p miden-stdlib"
72-
echo "2. Commit the changes in libcore/docs/"
71+
echo "1. Run: MIDEN_BUILD_LIB_DOCS=1 cargo build -p miden-core-lib"
72+
echo "2. Commit the changes in crates/lib/core/docs/"
7373
echo ""
7474
echo "Uncommitted changes:"
75-
git status libcore/docs
75+
git status crates/lib/core/docs
7676
echo ""
7777
echo "Diff:"
78-
git diff libcore/docs
78+
git diff crates/lib/core/docs
7979
exit 1
8080
else
81-
echo "No documentation changes in libcore/docs/ - OK"
81+
echo "No documentation changes in crates/lib/core/docs/ - OK"
8282
fi
8383
8484
check-features:

‎.gitignore‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
proptest-regressions/
1010

1111
# This is a file generated by the build process:
12-
libcore/assets/core.masl
12+
crates/lib/core/assets/core.masl
1313

1414
# These are files generated by MacOS
1515
**/.DS_Store

‎CHANGELOG.md‎

Lines changed: 1 addition & 1 deletion

‎Cargo.lock‎

Lines changed: 33 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Cargo.toml‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,20 @@
22
members = [
33
"air",
44
"core",
5-
"crates/*",
5+
"crates/assembly",
6+
"crates/assembly-syntax",
7+
"crates/debug-types",
8+
"crates/lib/core",
9+
"crates/mast-package",
10+
"crates/test-serde-macros",
11+
"crates/test-utils",
12+
"crates/utils-core-derive",
13+
"crates/utils-diagnostics",
14+
"crates/utils-indexing",
15+
"crates/utils-sync",
616
"miden-vm",
717
"processor",
818
"prover",
9-
"libcore",
1019
"verifier",
1120
]
1221
resolver = "2"
@@ -45,7 +54,7 @@ miden-mast-package = { path = "./crates/mast-package", version = "0.20", default
4554
miden-processor = { path = "./processor", version = "0.20", default-features = false }
4655
miden-test-serde-macros = { path = "./crates/test-serde-macros", default-features = false }
4756
miden-prover = { path = "./prover", version = "0.20", default-features = false }
48-
miden-libcore = { path = "./libcore", version = "0.20", default-features = false }
57+
miden-core-lib = { path = "./crates/lib/core", version = "0.20", default-features = false }
4958
miden-utils-core-derive = { path = "./crates/utils-core-derive", default-features = false }
5059
miden-utils-diagnostics = { path = "./crates/utils-diagnostics", version = "0.20", default-features = false }
5160
miden-utils-indexing = { path = "./crates/utils-indexing", version = "0.20", default-features = false }

‎Makefile‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ help:
1717
@printf " make test-miden-vm # Test miden-vm crate\n"
1818
@printf " make test-processor # Test processor crate\n"
1919
@printf " make test-prover # Test prover crate\n"
20-
@printf " make test-libcore # Test libcore crate\n"
20+
@printf " make test-core-lib # Test core-lib crate\n"
2121
@printf " make test-verifier # Test verifier crate\n"
2222
@printf "\nExamples:\n"
23-
@printf " make test-air test=\"some_test\" # Test specific function\n"
23+
@printf " make test-air test=\"some_test\" # Test specific function\n"
2424
@printf " make test-fast # Fast tests (no proptests/CLI)\n"
2525
@printf " make test-skip-proptests # All tests except proptests\n"
2626
@printf " make check-features # Check all feature combinations with cargo-hack\n\n"
@@ -29,7 +29,7 @@ help:
2929
# -- environment toggles --------------------------------------------------------------------------
3030
BACKTRACE := RUST_BACKTRACE=1
3131
WARNINGS := RUSTDOCFLAGS="-D warnings"
32-
BUILDDOCS := MIDEN_BUILD_LIBCORE_DOCS=1
32+
BUILDDOCS := MIDEN_BUILD_LIB_DOCS=1
3333

3434
# -- feature configuration ------------------------------------------------------------------------
3535
ALL_FEATURES_BUT_ASYNC := --features concurrent,executable,metal,testing,internal
@@ -51,7 +51,7 @@ FEATURES_core :=
5151
FEATURES_miden-vm := concurrent,executable,metal,internal
5252
FEATURES_processor := concurrent,testing,bus-debugger
5353
FEATURES_prover := concurrent,metal
54-
FEATURES_libcore :=FEATURES_verifier :=
54+
FEATURES_core-lib :=FEATURES_verifier :=
5555

5656
# -- linting --------------------------------------------------------------------------------------
5757

‎README.md‎

Lines changed: 2 additions & 2 deletions

‎core/src/mast/multi_forest_node_iterator.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ mod tests {
473473
/// processing the children of node 2.
474474
///
475475
/// This test and example is essentially a copy from a part of the MastForest of the Miden
476-
/// libcore where this failed on a previous implementation.
476+
/// core library where this failed on a previous implementation.
477477
#[test]
478478
fn multi_mast_forest_child_duplicate() {
479479
let mut temp_forest = MastForest::new();

‎core/src/precompile.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
//!
4545
//! # Example Implementation
4646
//!
47-
//! See the Keccak256 precompile in `miden_libcore::handlers::keccak256` for a complete reference
47+
//! See the Keccak256 precompile in `miden_core_lib::handlers::keccak256` for a complete reference
4848
//! implementation demonstrating both execution-time event handling and verification-time
4949
//! commitment recomputation.
5050
//!

‎crates/assembly/Cargo.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ thiserror.workspace = true
4242
# See: https://github.com/rust-lang/cargo/issues/2911#issuecomment-1483256987
4343
miden-assembly = { path = ".", default-features = false, features = ["testing"] }
4444
miden-mast-package = { workspace = true, features = ["arbitrary"] }
45-
miden-libcore = { path = "../../libcore", default-features = false }
45+
miden-core-lib = { workspace = true, default-features = false }
4646
miden-processor = { workspace = true, features = ["testing"] }
4747
insta.workspace = true
4848
proptest = { workspace = true, features = ["std"] }

0 commit comments

Comments
 (0)