Add support for Tuya "Bresser 7-in-1 Weatherstation" #149498
Conversation
There was a problem hiding this comment.
Hello @Nippey,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
-
eb453de16221be81dc3179bc9f61a314115c1955- This commit has something that looks like an email address (matthias.nippert@renesas.com). Maybe try linking that to GitHub?. -
2348911c098ede200fcccb37cea263e040f35c40- This commit has something that looks like an email address (matthias.nippert@renesas.com). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
d34184f to
6c0a4ea
Compare
| @@ -836,6 +836,24 @@ class TuyaSensorEntityDescription(SensorEntityDescription): | |||
| device_class=SensorDeviceClass.TEMPERATURE, | |||
| state_class=SensorStateClass.MEASUREMENT, | |||
| ), | |||
| TuyaSensorEntityDescription( | |||
| key=DPCode.TEMP_CURRENT_EXTERNAL_1, | |||
| translation_key="temperature_external_1", | |||
There was a problem hiding this comment.
Please use translation placeholder (with index)
There was a problem hiding this comment.
Thx a lot for the feedback! Im starting to understand how small my knowledge about HA actually is :O
Just to be sure:
- Should I set all to the same existing value? ("Probe temperature")
- Or Should I add new entries to strings.json matching the output of the SmartLife app? ("CH1 Temperature" / "CH1 Humidity")
There was a problem hiding this comment.
There should be some examples inside tuya... it should be something like this
| translation_key="temperature_external_1", | |
| translation_key="indexed_temperature_external", | |
| translation_placeholders={"index": 1} |
| ), | ||
| TuyaSensorEntityDescription( | ||
| key=DPCode.HUMIDITY_OUTDOOR_1, | ||
| translation_key="humidity_outdoor_1", |
There was a problem hiding this comment.
Use translation placeholder here also
| @@ -383,6 +399,7 @@ class DPCode(StrEnum): | |||
| UPPER_TEMP = "upper_temp" | |||
| UPPER_TEMP_F = "upper_temp_f" | |||
| UV = "uv" # UV sterilization | |||
| UV_INDEX = "uv_index" | |||
| @@ -274,6 +279,8 @@ class DPCode(StrEnum): | |||
| PUMP_RESET = "pump_reset" # Water pump reset | |||
| PUMP_TIME = "pump_time" # Water pump duration | |||
| OXYGEN = "oxygen" # Oxygen bar | |||
| RAIN_24H = "rain_24h" # mm | |||
Breaking change
None
Proposed change
Adding support for "product_name": "BR 7-in-1 WLAN Wetterstation Anthrazit",
Type of change
This weather station uses an existing Tuya sensor "qxj".
Therefore, I added more entities to it.
Additional information
Three more SensorEntities missing!
These need more work than just adding sensor entities and will be handled separately.
Checklist
I cannot set up the development environment and prepared this using the "custom_component" approach. :( Can we still continue somehow?
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: